Skip to content

[Optimization] Memoize OAuth config and separate theme effects in Login screen #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Optimization] Memoize OAuth config and separate theme effects in Login screen #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/pages/login.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { ImageBackground, Image } from "expo-image";
import * as Linking from "expo-linking";
import * as SystemUI from "expo-system-ui";
import * as WebBrowser from "expo-web-browser";
import { useContext, useEffect, useRef, useState } from "react";
import { useContext, useEffect, useMemo, useRef, useState } from "react";
import { Text, View, Animated, useColorScheme } from "react-native";
import { SafeAreaView } from "react-native-safe-area-context";

Expand Down Expand Up @@ -36,8 +36,8 @@ export default function Login() {

const signupParam = pendingSignup ?? false;

const [request, response, promptAsync] = useAuthRequest(
{
const authConfig = useMemo(
() => ({
clientId,
redirectUri,
scopes: ["read", "write"],
Expand All @@ -48,7 +48,12 @@ export default function Login() {
theme: scheme || "",
signup: signupParam.toString(),
},
},
}),
[signupParam, scheme],
);

const [request, response, promptAsync] = useAuthRequest(
authConfig,
discovery,
);

Expand Down Expand Up @@ -79,6 +84,9 @@ export default function Login() {
await SystemUI.setBackgroundColorAsync(isDark ? "#16161E" : "#F6F6F6");
};
setStatusBar();
}, [isDark]);

useEffect(() => {
if (!response || isProcessing) return;

const responseKey =
Expand Down Expand Up @@ -137,7 +145,7 @@ export default function Login() {
processedResponseRef.current = responseKey;
}
};
}, [response, request, setTokens, isProcessing, isDark]);
}, [response, request, setTokens, isProcessing]);

const doPrompt = async () => {
if (isPrompting) return;
Expand Down
Loading