Skip to content

Upgrade to Rails 7 #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albertchae opened this issue Oct 8, 2022 · 0 comments · Fixed by #3317
Closed

Upgrade to Rails 7 #3111

albertchae opened this issue Oct 8, 2022 · 0 comments · Fixed by #3317
Assignees
@albertchae

Comments

@albertchae
Copy link
Contributor

albertchae commented Oct 8, 2022 •
edited
Loading

After completion of #3008, we have somewhat of a test suite we can use to check that the app is still functioning as intended after upgrading Rails.

Bank is currently on Rails 6.1, so we can follow the steps at

At the minimum, make sure the following run:

  • bundle install
  • rails console
  • rails server
  • rspec

TODO
@albertchae albertchae self-assigned this Oct 8, 2022
@albertchae albertchae mentioned this issue Nov 23, 2022
Merged
@albertchae albertchae mentioned this issue Nov 23, 2022
Merged
albertchae added a commit that referenced this issue Nov 25, 2022
@albertchae
Wrap BankApiService in reloader callback (#3250)
b6bf6a9 
#3111

This fixes this deprecation warning which is an error in Rails 7

```
DEPRECATION WARNING: Initialization autoloaded the constants Util and BankApiService.

Being able to do this is deprecated. Autoloading during initialization is going
to be an error condition in future versions of Rails.

Reloading does not reboot the application, and therefore code executed during
initialization does not run again. So, if you reload Util, for example,
the expected changes won't be reflected in that stale Module object.

These autoloaded constants have been unloaded.

In order to autoload safely at boot time, please wrap your code in a reloader
callback this way:

    Rails.application.reloader.to_prepare do
      # Autoload classes and modules needed at boot time here.
    end

That block runs when the application boots, and every time there is a reload.
For historical reasons, it may run twice, so it has to be idempotent.

Check the "Autoloading and Reloading Constants" guide to learn more about how
Rails autoloads and reloads.
 (called from <top (required)> at /usr/src/app/config/environment.rb:7)
```
albertchae added a commit that referenced this issue Nov 25, 2022
@albertchae
Update rails gem from 6.1.6 to 6.1.7 (#3248)
857386b 
All tests pass

#3111

Before upgrading to Rails 7, we should first upgrade to the latest Rails 6
@albertchae albertchae mentioned this issue Nov 27, 2022
Closed
@albertchae albertchae mentioned this issue Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertchae albertchae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Rails 7 hackclub/hcb
Upgrade to Rails 7 hackclub/hcb
3 participants
@albertchae @sampoder @taciturnaxolotl