-
Notifications
You must be signed in to change notification settings - Fork 75
Replace is_signee with a new owner role #12019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
polypixeldev
wants to merge
32
commits into
main
Choose a base branch
from
polypixeldev/owner-role
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyhtou
reviewed
Dec 1, 2025
|
|
||
| organizer_position&.update!(fiscal_sponsorship_contract: contract) | ||
| organizer_position&.update!(role: :owner, fiscal_sponsorship_contract: contract) | ||
| update!(role: :owner) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disallow sending contracts to manager. Instead, the UI should allow you to change their role to owner; and as a result, a contract is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
The logic was starting to get a little confusing with signees being a different column than role, but signees must be a manager and there must be at least 1 signee per organization. Since roles are now fully shipped, it makes sense to make signees be an owner role that is above all other roles.
Closes #12012
Describe your changes
This PR does a few things:
is_signeecolumn onOrganizerPositionandOrganizerPositionInviteto reference the owner roleOneTimeJobs::BackfillOwnersto set each signee's role to ownerWhen this PR is merged:
Run
OneTimeJobs::BackfillOwners.performNext PRs:
is_signeecolumn onOrganizerPositionandOrganizerPositionInviteNote: While users can be promoted to the Owner role by an admin after accepting their invite to an organization, this will not automatically send them the contract. The best way for this to work might be to store organizer position roles as manager at first, and then promote to owner once the contract is signed. This should be considered when revamping contracts in the new onboarding flow.
Invite form:
