fix: Show error messages correctly in events and news articles #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tRPC may throw TRPErrors, so we cannot show the message from that error directly
|
It looks like tRPC's source code may throw TRPCError in some cases. Therefore we can confirm it's not safe to show the error messages directly. This security vulnerability is fixed in 4e9ba7c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now show the error message correctly.
I am however a little unsure if the approach is safe, because I'm not sure whether we're the only ones that can throw the TRPCError class. If some other part of the code in the procedure throws it, for example the auth, we could be risking exposing secrets
We could alternatively make the procedure return some kind of error object with the message