Update versions of lint libraries #201
Conversation
|
|
|
I've pulled updated code and downgraded version of typescript. |
gollumnima
changed the title
| // const pointers = { | ||
| // mouseup: 'pointerup', | ||
| // mouseout: 'pointerup', | ||
| // mousedown: 'pointerdown', | ||
| // mousemove: 'pointermove', | ||
| // }; | ||
|
|
||
| const microsoft = { | ||
| mouseup: 'MSPointerUp', | ||
| mouseout: 'MSPointerUp', | ||
| mousedown: 'MSPointerDown', | ||
| mousemove: 'MSPointerMove', | ||
| }; | ||
| // const microsoft = { | ||
| // mouseup: 'MSPointerUp', | ||
| // mouseout: 'MSPointerUp', | ||
| // mousedown: 'MSPointerDown', | ||
| // mousemove: 'MSPointerMove', | ||
| // }; |
There was a problem hiding this comment.
Please delete the comments of old code.
| // if (global.navigator.pointerEnabled) { | ||
| // event(el, pointers[type], fn); | ||
| // } else if (global.navigator.msPointerEnabled) { | ||
| // event(el, microsoft[type], fn); | ||
| // } else { | ||
| event(el, touch[type], fn); | ||
| event(el, type, fn); | ||
| // } |
|
CI build fails because |
|
@blurfx I've rolled back the code. Sorry for the late response. |
|
@gollumnima I think I missed something. Why did you commented these codes before? to remove or just temporary? |
|
@blurfx Because when I updated the version of typescript, the commented code made type error. So I just rolled back to the previous version. At the time, I was considering whether updating the version of typescript and making d.ts file to fix type error or just removing this code. I thought I had left a note for this somewhere, but I cannot find any note🥲 |
|
@gollumnima Sorry for late response. I think we can drop old browser support through remove these commented codes. |
|
|
|
@gollumnima I think some empty dependencies are intended. How about changing the eslint |
|
@blurfx I think our ci rule is too strict for the lint issue 🥲. |
|
The warning was treated as an error when the action runner set Now we have many ways to solve this problem.
|
|
@blurfx Finally...! |
|
Great work 😄 Thank you for your contribution! |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable react-hooks/exhaustive-deps */ | |||
There was a problem hiding this comment.
I think disabling the lint rules makes it more explicit to specify line numbers using eslint-disable-line or eslint-disable-next-line comment.
Reference: Disabling Rules - ESLint
@gollumnima @blurfx Would it be okay could I work on this proposal? 🥺
There was a problem hiding this comment.
@x86chi Yes, and if you found an unintentional empty dependency array, could you please update it instead of using eslint-disable comment?
What this PR does / why we need it?
package.json.Any background context you want to provide?
I've uploaded issue with type on #196
Do I roll back typescript to previous version for the backward compatibility or just add type file for navigator?
What are the relevant tickets?
Working on #196
Checklist