-
-
Notifications
You must be signed in to change notification settings - Fork 35
Add gunicorn and Whitenoise, and set up Dockerfile-aws and entrypoint-aws.sh #672 #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drakeredwind01
wants to merge
5
commits into
main
Choose a base branch
from
drake_672_dockerfile_aws_setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dc2bdb8
solving, Split requirements into dev and AWS #671
drakeredwind01 06a4083
solving, 672, Add gunicorn and Whitenoise, and set up Dockerfile-aws …
drakeredwind01 d7a7610
fix: add drf-spectacular, urls_aws.py, and Python 3.10 pin for #672
drakeredwind01 8de12bf
fix: add STATIC_ROOT and whitenoise STORAGES to settings_aws.py for c…
drakeredwind01 e920dc3
replacing forgotten docker-compose-aws.yml
drakeredwind01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #!/bin/sh | ||
|
|
||
| python manage.py migrate | ||
| python manage.py migrate --noinput | ||
|
|
||
| exec "$@" | ||
| exec gunicorn peopledepot.wsgi:application --bind 0.0.0.0:8000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| from .settings import * # noqa: F401, F403 | ||
|
drakeredwind01 marked this conversation as resolved.
Fixed
|
||
|
|
||
| ROOT_URLCONF = "peopledepot.urls_aws" | ||
|
|
||
| INSTALLED_APPS = [ | ||
| "django.contrib.admin", | ||
| "django.contrib.auth", | ||
| "django.contrib.contenttypes", | ||
| "django.contrib.sessions", | ||
| "django.contrib.messages", | ||
| "django.contrib.staticfiles", | ||
| # 3rd party | ||
| "django_extensions", | ||
| "rest_framework", | ||
| "phonenumber_field", | ||
| "timezone_field", | ||
| # Local | ||
| "core", | ||
| "data", | ||
| ] | ||
|
|
||
| REST_FRAMEWORK = { | ||
| "DEFAULT_PERMISSION_CLASSES": ("core.api.permissions.DenyAny",), | ||
| "DEFAULT_AUTHENTICATION_CLASSES": ( | ||
| "rest_framework_jwt.authentication.JSONWebTokenAuthentication", | ||
| ), | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| from django.contrib import admin | ||
| from django.http import HttpResponse | ||
| from django.urls import include | ||
| from django.urls import path | ||
|
|
||
|
|
||
| def index(request): | ||
| return HttpResponse("You're at the peopledepot index.") | ||
|
|
||
|
|
||
| urlpatterns = [ | ||
| path("", index), | ||
| path("admin/", admin.site.urls), | ||
| path("api/v1/", include("core.api.urls")), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| django~=4.2.27 | ||
| django-extensions | ||
| django-phonenumber-field[phonenumbers] | ||
| django-timezone-field | ||
| djangorestframework | ||
| drf-jwt | ||
| drf-spectacular | ||
| gunicorn | ||
| psycopg2-binary | ||
| tzdata | ||
| whitenoise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| asgiref==3.11.1 | ||
| # via django | ||
| attrs==26.1.0 | ||
| # via | ||
| # jsonschema | ||
| # referencing | ||
| cffi==2.0.0 | ||
| # via cryptography | ||
| cryptography==48.0.1 | ||
| # via pyjwt | ||
| django==4.2.30 | ||
| # via | ||
| # -r requirements-aws.in | ||
| # django-extensions | ||
| # django-phonenumber-field | ||
| # django-timezone-field | ||
| # djangorestframework | ||
| # drf-jwt | ||
| # drf-spectacular | ||
| django-extensions==4.1 | ||
| # via -r requirements-aws.in | ||
| django-phonenumber-field==8.4.0 | ||
| # via -r requirements-aws.in | ||
| django-timezone-field==7.2.2 | ||
| # via -r requirements-aws.in | ||
| djangorestframework==3.17.1 | ||
| # via | ||
| # -r requirements-aws.in | ||
| # drf-jwt | ||
| # drf-spectacular | ||
| drf-jwt==1.19.2 | ||
| # via -r requirements-aws.in | ||
| drf-spectacular==0.29.0 | ||
| # via -r requirements-aws.in | ||
| gunicorn==26.0.0 | ||
| # via -r requirements-aws.in | ||
| inflection==0.5.1 | ||
| # via drf-spectacular | ||
| jsonschema==4.26.0 | ||
| # via drf-spectacular | ||
| jsonschema-specifications==2025.9.1 | ||
| # via jsonschema | ||
| packaging==26.2 | ||
| # via gunicorn | ||
| phonenumbers==9.0.32 | ||
| # via django-phonenumber-field | ||
| psycopg2-binary==2.9.12 | ||
| # via -r requirements-aws.in | ||
| pycparser==3.0 | ||
| # via cffi | ||
| pyjwt==2.13.0 | ||
| # via drf-jwt | ||
| pyyaml==6.0.3 | ||
| # via drf-spectacular | ||
| referencing==0.37.0 | ||
| # via | ||
| # jsonschema | ||
| # jsonschema-specifications | ||
| rpds-py==0.30.0 | ||
| # via | ||
| # jsonschema | ||
| # referencing | ||
| sqlparse==0.5.5 | ||
| # via django | ||
| typing-extensions==4.15.0 | ||
| # via | ||
| # asgiref | ||
| # cryptography | ||
| # pyjwt | ||
| # referencing | ||
| tzdata==2026.2 | ||
| # via -r requirements-aws.in | ||
| uritemplate==4.2.0 | ||
| # via drf-spectacular | ||
| whitenoise==6.12.0 | ||
| # via -r requirements-aws.in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,9 @@ app/ | |
| ├── manage.py # (7)! | ||
| ├── requirements.in # (8)! | ||
| ├── requirements.txt # (9)! | ||
| └── setup.cfg # (10)! | ||
| ├── requirements-aws.in # (10)! | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add the other new If you wan to simplify it and have a single number say some thing like "The aws configuration for the corresponding development file", that works too. Whatever way you prefer is fine. |
||
| ├── requirements-aws.txt # (11)! | ||
| └── setup.cfg # (12)! | ||
| ``` | ||
|
|
||
| 1. The core app in django. This app contains the API and models. See [Core App](#core-app) below for details. | ||
|
|
@@ -47,8 +49,10 @@ app/ | |
| 1. Dockerfile used to build the Docker image. | ||
| 1. Entrypoint script called by the Docker image. | ||
| 1. Django manage.py script. In nearly all cases, there's no good reason to change this. Just leave it alone. | ||
| 1. Requirements.in file used by `uv pip compile`. See the [uv tool](uv.md) for details. | ||
| 1. Requirements.txt file generated by `uv pip install`. Do not modify this file. Edit the `requirements.in` file instead. See the [uv tool](uv.md) for details. | ||
| 1. Development requirements source file used by `uv pip compile`. Contains all dependencies including dev/test packages. See the [uv tool](uv.md) for details. | ||
| 1. Development requirements file generated from `requirements.in`. Do not modify this file directly. Edit `requirements.in` instead. See the [uv tool](uv.md) for details. | ||
| 1. AWS/production requirements source file. Contains only production dependencies — no dev or test packages. | ||
| 1. AWS/production requirements file generated from `requirements-aws.in`. Do not modify this file directly. Edit `requirements-aws.in` instead. | ||
| 1. Config file for development support tools such as `flake8` and `pytest`. `flake8` is the only tool that doesn't support `pyproject.toml` yet, which is why we have this file. | ||
|
|
||
| #### Core App | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is supposed to be from the changes for the prior PR. But anyway, this is not such a good idea since it won't fail if DJANGO_ALLOWED_HOSTS is undefined. The server will start and drop all outside connections.