Update deployment workflow #675#686
Open
drakeredwind01 wants to merge 8 commits into
Open
Conversation
…and entrypoint-aws.sh #672
Single-stage: 74MB → multi-stage: 60.7MB (18% reduction)
| @@ -0,0 +1,37 @@ | |||
| from .settings import * # noqa: F401, F403 | |||
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #675
Update deployment workflow #675
Most action items already handled in #672–674
deploy-dev.ymlalready usesdocker build -f Dockerfile-awsrequirements-aws.txtreferenced insideDockerfile-aws— picked up automaticallysettings_aws.pyset viaENV DJANGO_SETTINGS_MODULEinDockerfile-awsentrypoint-aws.shis theENTRYPOINTinDockerfile-awsentrypoint-aws.shPre-implementation concerns
1. BuildKit not explicitly enabled — NOT mentioned in the issue
Dockerfile-awsuses--mount=type=cachewhich requires BuildKit. GitHub Actions enables BuildKit by default on recent Docker versions but it is not guaranteed and is not explicitly set in the workflow. If missing, the build fails with a syntax error on the--mountlines.Fix: added
DOCKER_BUILDKIT: 1to the build step'senvblock indeploy-dev.yml.2. Documentation update — IS mentioned in the issue
docs/contributing/reference/aws-resources.mdalready referencesDockerfile-awsandentrypoint-aws.shbut needed additions: gunicorn as the WSGI server, whitenoise for static files, andsettings_aws.pyas the production settings module.Files updated:
.github/workflows/deploy-dev.yml— addedDOCKER_BUILDKIT: 1to build step env blockdocs/contributing/reference/aws-resources.md— updated step 4 to mention gunicorn and whitenoise; addedsettings_aws.pyto Docker & App Startup sectionCloses #219