Skip to content

Fix text field positioning in modal/popup presentations #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix text field positioning in modal/popup presentations #2134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6792912
Initial plan
Copilot Sep 19, 2025
d41f591
Fix coordinate conversion for popup presentations
Copilot Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions IQKeyboardManager/IQKeyboardManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,17 @@ -(void)adjustPosition

// Converting Rectangle according to window bounds.
CGRect textFieldViewRectInWindow = [[textFieldView superview] convertRect:textFieldView.frame toView:keyWindow];
CGRect textFieldViewRectInRootSuperview = [[textFieldView superview] convertRect:textFieldView.frame toView:rootController.view.superview];
CGRect textFieldViewRectInRootSuperview;

// For modal presentations, rootController.view.superview can be nil or point to an incorrect coordinate space
// Convert to window coordinates and then to rootController.view coordinates to ensure proper positioning
if (rootController.view.superview != nil) {
textFieldViewRectInRootSuperview = [[textFieldView superview] convertRect:textFieldView.frame toView:rootController.view.superview];
} else {
// When superview is nil (common in modal presentations), convert to window then to root view
CGRect rectInWindow = [[textFieldView superview] convertRect:textFieldView.frame toView:keyWindow];
textFieldViewRectInRootSuperview = [keyWindow convertRect:rectInWindow toView:rootController.view];
}
// Getting RootView origin.
CGPoint rootViewOrigin = rootController.view.frame.origin;

Expand Down Expand Up @@ -962,7 +972,13 @@ -(void)adjustPosition
CGRect previousCellRect = [tableView rectForRowAtIndexPath:previousIndexPath];
if (CGRectIsEmpty(previousCellRect) == NO)
{
CGRect previousCellRectInRootSuperview = [tableView convertRect:previousCellRect toView:rootController.view.superview];
CGRect previousCellRectInRootSuperview;
if (rootController.view.superview != nil) {
previousCellRectInRootSuperview = [tableView convertRect:previousCellRect toView:rootController.view.superview];
} else {
CGRect rectInWindow = [tableView convertRect:previousCellRect toView:keyWindow];
previousCellRectInRootSuperview = [keyWindow convertRect:rectInWindow toView:rootController.view];
}
moveUp = MIN(0, CGRectGetMaxY(previousCellRectInRootSuperview) - topLayoutGuide);
}
}
Expand All @@ -987,7 +1003,13 @@ -(void)adjustPosition
CGRect previousCellRect = attributes.frame;
if (CGRectIsEmpty(previousCellRect) == NO)
{
CGRect previousCellRectInRootSuperview = [collectionView convertRect:previousCellRect toView:rootController.view.superview];
CGRect previousCellRectInRootSuperview;
if (rootController.view.superview != nil) {
previousCellRectInRootSuperview = [collectionView convertRect:previousCellRect toView:rootController.view.superview];
} else {
CGRect rectInWindow = [collectionView convertRect:previousCellRect toView:keyWindow];
previousCellRectInRootSuperview = [keyWindow convertRect:rectInWindow toView:rootController.view];
}
moveUp = MIN(0, CGRectGetMaxY(previousCellRectInRootSuperview) - topLayoutGuide);
}
}
Expand Down Expand Up @@ -1167,7 +1189,13 @@ -(void)adjustPosition

CGFloat keyboardYPosition = CGRectGetHeight(keyWindow.frame)-originalKbSize.height;

CGRect rootSuperViewFrameInWindow = [rootController.view.superview convertRect:rootController.view.superview.bounds toView:keyWindow];
CGRect rootSuperViewFrameInWindow;
if (rootController.view.superview != nil) {
rootSuperViewFrameInWindow = [rootController.view.superview convertRect:rootController.view.superview.bounds toView:keyWindow];
} else {
// Use the window frame as a fallback for modal presentations
rootSuperViewFrameInWindow = keyWindow.frame;
}

CGFloat keyboardOverlapping = CGRectGetMaxY(rootSuperViewFrameInWindow) - keyboardYPosition;

Expand Down
13 changes: 11 additions & 2 deletions IQKeyboardManagerSwift/IQKeyboardManager/IQKeyboardManager+Position.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,17 @@ import IQKeyboardCore
}

let textInputViewRectInWindow: CGRect = superview.convert(textInputView.frame, to: window)
let textInputViewRectInRootSuperview: CGRect = superview.convert(textInputView.frame,
to: rootController.view.superview)
let textInputViewRectInRootSuperview: CGRect = {
// For modal presentations, rootController.view.superview can be nil or point to an incorrect coordinate space
// Convert to window coordinates and then to rootController.view coordinates to ensure proper positioning
if let rootSuperview = rootController.view.superview {
return superview.convert(textInputView.frame, to: rootSuperview)
} else {
// When superview is nil (common in modal presentations), convert to window then to root view
let rectInWindow = superview.convert(textInputView.frame, to: window)
return window.convert(rectInWindow, to: rootController.view)
}
}()

// Getting RootViewOrigin.
let rootViewOrigin: CGPoint = rootController.view.frame.origin
Expand Down