feat: add --out-of-scope domain filtering option #876
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| package optimization | ||
|
|
||
| import ( | ||
| "net/url" | ||
| "strings" | ||
|
|
||
| "github.com/hahwul/dalfox/v2/pkg/model" | ||
| ) | ||
|
|
||
| // IsOutOfScope checks if a URL's host matches any out-of-scope pattern. | ||
| // Supports wildcard matching: | ||
| // - "stg.example.com" = exact match only | ||
| // - "*.stg.example.com" = matches subdomains (api.stg.example.com, devapi.stg.example.com) | ||
| func IsOutOfScope(options model.Options, targetURL string) bool { | ||
| if len(options.OutOfScope) == 0 { | ||
| return false | ||
| } | ||
|
|
||
| parsedURL, err := url.Parse(targetURL) | ||
| if err != nil { | ||
| // Treat malformed URLs as out-of-scope for safety | ||
| return true | ||
| } | ||
|
|
||
| host := strings.ToLower(parsedURL.Hostname()) | ||
| // Handle URLs without scheme - url.Parse puts them in Path with empty Host | ||
| if host == "" && parsedURL.Path != "" { | ||
| parsedURL, err = url.Parse("http://" + targetURL) | ||
| if err != nil { | ||
| return true | ||
| } | ||
| host = strings.ToLower(parsedURL.Hostname()) | ||
| } | ||
| for _, pattern := range options.OutOfScope { | ||
| pattern = strings.ToLower(strings.TrimSpace(pattern)) | ||
| if matchDomainPattern(host, pattern) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| // matchDomainPattern checks if host matches the pattern. | ||
| // Pattern "*.example.com" matches "sub.example.com" but not "example.com" | ||
| // Pattern "example.com" matches only "example.com" exactly | ||
| func matchDomainPattern(host, pattern string) bool { | ||
| if strings.HasPrefix(pattern, "*.") { | ||
| suffix := pattern[1:] // ".example.com" | ||
| return strings.HasSuffix(host, suffix) | ||
| } | ||
| return host == pattern | ||
| } | ||
|
|
||
| // FilterOutOfScopeTargets removes out-of-scope URLs from a target list | ||
| func FilterOutOfScopeTargets(options model.Options, targets []string) []string { | ||
| if len(options.OutOfScope) == 0 { | ||
| return targets | ||
| } | ||
|
|
||
| filtered := make([]string, 0, len(targets)) | ||
| for _, target := range targets { | ||
| if !IsOutOfScope(options, target) { | ||
| filtered = append(filtered, target) | ||
| } | ||
| } | ||
| return filtered | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
optimization.FilterOutOfScopeTargetsfunction already checks ifoptions.OutOfScopeis empty and returns early. This outerifcondition is therefore redundant and can be removed to simplify the code.