new add metrics #463
Open
new add metrics #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r350178982
reviewed
Jan 6, 2025
app/event_redis.py
Outdated
| def lrem(self, key, count): | ||
| return self.connection.lrem(key, count) | ||
|
|
||
| def publisher(self, channel, message): |
There was a problem hiding this comment.
publisher --> publish, publisher 是名词这里应该使用动词
r350178982
reviewed
Jan 6, 2025
app/event_redis.py
Outdated
| def lpush(self, key, value): | ||
| return self.connection.lpush(key, value) | ||
|
|
||
| def lrem(self, key, count): |
r350178982
reviewed
Jan 6, 2025
app/event_redis.py
Outdated
| def lpush(self, key, value): | ||
| return self._redis_client.lpush(key, value) | ||
|
|
||
| def lrem(self, key, count): |
r350178982
reviewed
Jan 6, 2025
events/metrics.py
Outdated
| "instance_name": "seafevents", | ||
| "node_name": node_name, | ||
| "details": { | ||
| "collected_at": datetime.datetime.utcnow().isoformat() |
r350178982
reviewed
Jan 6, 2025
seafevent_server/request_handler.py
Outdated
| } | ||
| } | ||
| if ENABLE_METRIC: | ||
| redis_cache.publisher('metric-channel', json.dumps(publish_metric)) |
There was a problem hiding this comment.
这种重复的逻辑在外部增加一个函数， def publish_io_qsize_metric(qsize)
r350178982
reviewed
Jan 6, 2025
app/app.py
Outdated
| @@ -38,6 +39,10 @@ def __init__(self, config, seafile_config, | |||
| self._file_updates_sender = FileUpdatesSender() | |||
| self._repo_old_file_auto_del_scanner = RepoOldFileAutoDelScanner(config) | |||
| self._deleted_files_count_cleaner = DeletedFilesCountCleaner(config) | |||
| if ENABLE_METRIC: | |||
| self._metric_collect = MetricRedisRecord() | |||
There was a problem hiding this comment.
改一下名字， self._metric_redis_recorder = MetricRedisRecorder()
r350178982
reviewed
Jan 6, 2025
events/metrics.py
Outdated
|
|
||
| local_metric = {'metrics': {}} | ||
|
|
||
| node_name = os.environ.get('NODE_NAME', 'default') |
added 2 commits
January 6, 2025 11:03
r350178982
reviewed
Jan 6, 2025
events/metrics.py
Outdated
| local_metric = {'metrics': {}} | ||
|
|
||
| NODE_NAME = os.environ.get('NODE_NAME', 'default') | ||
|
|
There was a problem hiding this comment.
METRIC_CHANNEL_NAME= “metic-channel”
r350178982
reviewed
Jan 6, 2025
events/metrics.py
Outdated
| if message is not None: | ||
| metric_data = json.loads(message['data']) | ||
| try: | ||
| key_name = metric_data.get('instance_name') + ':' + metric_data.get('node_name') + ':' + metric_data.get('metric_name') |
There was a problem hiding this comment.
metric_data.get('node_name')， 需要处理一下， 没有node_name的key时为default的情景
r350178982
reviewed
Jan 6, 2025
events/metrics.py
Outdated
| metric_data = json.loads(message['data']) | ||
| try: | ||
| key_name = metric_data.get('instance_name') + ':' + metric_data.get('node_name') + ':' + metric_data.get('metric_name') | ||
| metric_details = metric_data.get('details', {}) |
There was a problem hiding this comment.
metric_data.get('details') or {}
r350178982
reviewed
Jan 6, 2025
|
|
||
| app = Flask(__name__) | ||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def publish_io_qsize_metric(qsize): |
There was a problem hiding this comment.
这里先判断， if not ENABLE_METRIC: return, 不需要开辟空间列出一个字典
r350178982
reviewed
Jan 6, 2025
events/metrics.py
Outdated
| else: | ||
| metric_info += metric_name + str(metric_value) + '\n' | ||
|
|
||
| cache.delete("metrics") |
freeplant
reviewed
Jan 7, 2025
events/metrics.py
Outdated
| local_metric = {'metrics': {}} | ||
|
|
||
| NODE_NAME = os.environ.get('NODE_NAME', 'default') | ||
| METRIC_CHANNEL_NAME = "metic-channel" |
There was a problem hiding this comment.
metic-channel -> metric-channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.