Bug fix: CRUDController and DynamicCrudController 'renderForm' signatures do not match, causing 'render' to be used and resulting in a TemplateNotFoundException #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where CRUDController would not return control to an instance of DynamicCrudController subclass when rendering a form because the signatures of the two renderForm methods did not match so the generic render method was called instead of renderForm.
Add the Override corresponding to the change in the CRUDContoller superclass. This fixes a subtle bug by allowing calls to 'renderForm' to find the correct method instead of reverting to the generic 'render' method, and thereby find the correct view and avoid a TemplateNotFoundException.
Update DynamicCrudController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where CRUDController would not return control to an instance of DynamicCrudController when rendering a form because the signatures of the two renderForm methods did not match.