Skip to content

GitHub Actions and fewer false positives #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halotroop2288 merged 2 commits into from
Sep 15, 2021
Merged

GitHub Actions and fewer false positives #2

halotroop2288 merged 2 commits into from
Sep 15, 2021

Conversation

@macbrayne
Copy link
Contributor

@macbrayne macbrayne commented Sep 11, 2021 •
edited
Loading

  • sets up a GitHub actions workflow which provides artifacts
  • adds more licenses (lgpl, cc-by-nc) and improves license parsing ('-' → ' ')
  • upgrades to gradle 7.2
  • updates loom to 0.9-SNAPSHOT and fabric loader to 0.11.6
  • specifies yarn mappings
  • adds long form lgpl and cc-by-nc licenses
  • move name and license parsing to using regexes instead of string replacement

halotroop2288
halotroop2288 reviewed Sep 11, 2021
View reviewed changes
halotroop2288
halotroop2288 reviewed Sep 11, 2021
View reviewed changes
@halotroop2288 halotroop2288 self-assigned this Sep 11, 2021
halotroop2288
halotroop2288 requested changes Sep 11, 2021
View reviewed changes
@halotroop2288 halotroop2288 added bug Something isn't working enhancement New feature or request labels Sep 11, 2021
@macbrayne macbrayne marked this pull request as draft September 11, 2021 21:06
@macbrayne
Copy link
Contributor Author

macbrayne commented Sep 11, 2021

Marking it as draft because I'd like to rebase it before merging

@macbrayne macbrayne force-pushed the patch-1 branch 3 times, most recently from 82afea6 to 3de2d95 Compare September 13, 2021 18:46
@macbrayne macbrayne marked this pull request as ready for review September 13, 2021 18:47
halotroop2288
halotroop2288 requested changes Sep 13, 2021
View reviewed changes
@macbrayne
update loom to 0.9-SNAPSHOT
64e68f2 
upgrade to gradle 7.2
update fabric loader to 0.11.6
specify yarn mappings

add long form lgpl and cc-by-nc licenses
move to using regexes instead of string replacement
move to using metadata for ignoring mods instead of a ignorelist
@macbrayne
add GitHub Actions build script
c29a7fa
halotroop2288
halotroop2288 approved these changes Sep 15, 2021
View reviewed changes
@halotroop2288 halotroop2288 merged commit 33e34df into halotroop2288:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halotroop2288 halotroop2288 halotroop2288 approved these changes

Assignees

@halotroop2288 halotroop2288

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macbrayne @halotroop2288