Skip to content

Failing test for #152 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Failing test for #152 #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b15c759
Failing test for issue #152
hakanai Mar 12, 2020
42e69bb
Fixing a lost cause for an exception path
hakanai Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hamcrest/src/main/java/org/hamcrest/beans/HasPropertyWithValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public Condition<Object> apply(Method readMethod, Description mismatch) {
return notMatched();
} catch (Exception e) {
throw new IllegalStateException(
"Calling: '" + readMethod + "' should not have thrown " + e);
"Calling: '" + readMethod + "' should not have thrown", e);
}
}
};
Expand Down
13 changes: 12 additions & 1 deletion hamcrest/src/test/java/org/hamcrest/beans/HasPropertyWithValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
package org.hamcrest.beans;

import org.hamcrest.*;
import org.hamcrest.AbstractMatcherTest;
import org.hamcrest.Description;
import org.hamcrest.Matcher;
import org.hamcrest.StringDescription;
import org.hamcrest.core.IsEqual;

import java.beans.IntrospectionException;
import java.beans.PropertyDescriptor;
import java.beans.SimpleBeanInfo;
import java.nio.file.Path;
import java.nio.file.Paths;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.hasToString;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.beans.HasPropertyWithValue.hasProperty;
import static org.hamcrest.beans.HasPropertyWithValue.hasPropertyAtPath;
Expand Down Expand Up @@ -71,6 +77,11 @@ public void testMatchesPath() {
assertMismatchDescription("inner.inner.property.was \"not expected\"", hasPropertyAtPath("inner.inner.property", equalTo("something")), new BeanWithInner(new BeanWithInner(shouldNotMatch)));
}

public void testMatchesAbstract() {
Path path = Paths.get("hi.txt");
assertThat(path, hasProperty("fileName", hasToString("hi.txt")));
}

public void testDescribeTo() {
assertDescription("hasProperty(\"property\", <true>)", hasProperty("property", equalTo(true)));
}
Expand Down