Initialize Rom org, add rom-factory#129
Conversation
🔄 Sync summary❇️ rom-rb/rom-factory (17 files in e3767fe)
|
🔄 Sync summary⚪ dry-rb/dry-auto_inject ⚪ dry-rb/dry-cli ⚪ dry-rb/dry-configurable ⚪ dry-rb/dry-core ⚪ dry-rb/dry-effects ⚪ dry-rb/dry-events ⚪ dry-rb/dry-files ⚪ dry-rb/dry-inflector ⚪ dry-rb/dry-initializer ⚪ dry-rb/dry-logger ⚪ dry-rb/dry-logic ⚪ dry-rb/dry-matcher ⚪ dry-rb/dry-monads ⚪ dry-rb/dry-monitor ⚪ dry-rb/dry-operation ⚪ dry-rb/dry-rails ⚪ dry-rb/dry-schema ⚪ dry-rb/dry-struct ⚪ dry-rb/dry-system ⚪ dry-rb/dry-transaction ⚪ dry-rb/dry-transformer ⚪ dry-rb/dry-types ⚪ dry-rb/dry-validation |
🔄 Sync summary⚪ hanami/hanami ⚪ hanami/hanami-action ⚪ hanami/hanami-assets ⚪ hanami/hanami-cli ⚪ hanami/hanami-controller-stub ⚪ hanami/hanami-db ⚪ hanami/hanami-mailer ⚪ hanami/hanami-reloader ⚪ hanami/hanami-router ⚪ hanami/hanami-rspec ⚪ hanami/hanami-utils ⚪ hanami/hanami-validations ⚪ hanami/hanami-webconsole ⚪ hanami/hanami-view |
|
@timriley okay I think I'm up to speed on your alterations to accommodate multiple orgs, here's my best-effort at adding the first ROM project. |
|
We should also update |
🔄 Sync summary⚪ hanami/hanami-assets-js |
@katafrakt I think this "just works" now, i.e. we don't need to make explicit changes to that tooling every time we add a new group. I've actually just merged #128, which renames After merging that and fixing a conflict here in this brach, I used local-sync and everything looks good: Was there anything else you had in mind with your comment, @katafrakt? |
timriley
left a comment
There was a problem hiding this comment.
Thanks for taking this on, @alassek! Everything looks good to me.
As you'll note in the commit history, I did a bit of tidying up after deciding to merging #128, to make sure everything still worked for your change here.
It's all looking good now! I notice for some reason the JRuby job is still hard-failing in rom-factory CI, but I'm happy for you to tackle that on whatever order you see fit :)
|
@timriley yes, functionally it should look good. I was thinking more about all the help texts etc., which list supported values for |
|
@katafrakt ah, right! Yes, that makes sense. We don't have many groups, so we may as well be helpful and show every possible value in the help text 👍 |
No description provided.