Skip to content

Initialize Rom org, add rom-factory#129

Open
alassek wants to merge 3 commits into
mainfrom
rom-factory
Open

Initialize Rom org, add rom-factory#129
alassek wants to merge 3 commits into
mainfrom
rom-factory

Conversation

@alassek

@alassek alassek commented May 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

🔄 Sync summary

❇️ rom-rb/rom-factory (17 files in e3767fe)

  • .github/ISSUE_TEMPLATE/bug-report.md
  • .github/ISSUE_TEMPLATE/config.yml
  • .github/SUPPORT.md
  • .github/workflows/ci.yml
  • .github/workflows/pr-comments.yml
  • .github/workflows/repo-sync-preview.yml
  • .github/workflows/rubocop.yml
  • .github/workflows/ci-lint.yml
  • CODE_OF_CONDUCT.md
  • CONTRIBUTING.md
  • rom-factory.gemspec
  • LICENSE
  • README.md
  • spec/support/coverage.rb
  • spec/support/rspec.rb
  • spec/support/warnings.rb
  • zizmor.yml

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

🔄 Sync summary

dry-rb/dry-auto_inject

dry-rb/dry-cli

dry-rb/dry-configurable

dry-rb/dry-core

dry-rb/dry-effects

dry-rb/dry-events

dry-rb/dry-files

dry-rb/dry-inflector

dry-rb/dry-initializer

dry-rb/dry-logger

dry-rb/dry-logic

dry-rb/dry-matcher

dry-rb/dry-monads

dry-rb/dry-monitor

dry-rb/dry-operation

dry-rb/dry-rails

dry-rb/dry-schema

dry-rb/dry-struct

dry-rb/dry-system

dry-rb/dry-transaction

dry-rb/dry-transformer

dry-rb/dry-types

dry-rb/dry-validation

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

🔄 Sync summary

hanami/hanami

hanami/hanami-action

hanami/hanami-assets

hanami/hanami-cli

hanami/hanami-controller-stub

hanami/hanami-db

hanami/hanami-mailer

hanami/hanami-reloader

hanami/hanami-router

hanami/hanami-rspec

hanami/hanami-utils

hanami/hanami-validations

hanami/hanami-webconsole

hanami/hanami-view

@alassek alassek requested a review from timriley May 3, 2026 02:12
@alassek

alassek commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

@timriley okay I think I'm up to speed on your alterations to accommodate multiple orgs, here's my best-effort at adding the first ROM project.

@katafrakt

Copy link
Copy Markdown
Contributor

We should also update bin/local-sync to support rom as value for --org param (basically similar changes to 993255d).

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

🔄 Sync summary

hanami/hanami-assets-js

@timriley

timriley commented May 4, 2026

Copy link
Copy Markdown
Member

We should also update bin/local-sync to support rom as value for --org param (basically similar changes to 993255d).

@katafrakt I think this "just works" now, i.e. we don't need to make explicit changes to that tooling every time we add a new group.

I've actually just merged #128, which renames --org to --group (this fits better with our ability to split gems not just along org lines, as we have now done with hanami and hanami-js.

After merging that and fixing a conflict here in this brach, I used local-sync and everything looks good:

❯ bin/local-sync --group rom tmp/rom-factory/
Changes:
 M .github/ISSUE_TEMPLATE/bug-report.md
 M .github/ISSUE_TEMPLATE/config.yml
 M .github/SUPPORT.md
 M .github/workflows/ci.yml
 M .github/workflows/rubocop.yml
 M CODE_OF_CONDUCT.md
 M CONTRIBUTING.md
 M LICENSE
 M README.md
 M rom-factory.gemspec
 M spec/support/coverage.rb
 M spec/support/warnings.rb
?? .github/workflows/ci-lint.yml
?? .github/workflows/pr-comments.yml
?? .github/workflows/repo-sync-preview.yml
?? spec/support/rspec.rb
?? zizmor.yml

Was there anything else you had in mind with your comment, @katafrakt?

@timriley timriley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, @alassek! Everything looks good to me.

As you'll note in the commit history, I did a bit of tidying up after deciding to merging #128, to make sure everything still worked for your change here.

It's all looking good now! I notice for some reason the JRuby job is still hard-failing in rom-factory CI, but I'm happy for you to tackle that on whatever order you see fit :)

@katafrakt

Copy link
Copy Markdown
Contributor

@timriley yes, functionally it should look good. I was thinking more about all the help texts etc., which list supported values for org group param.

@timriley

timriley commented May 4, 2026

Copy link
Copy Markdown
Member

@katafrakt ah, right! Yes, that makes sense. We don't have many groups, so we may as well be helpful and show every possible value in the help text 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants