-
Notifications
You must be signed in to change notification settings - Fork 47
[2팀 김우정] Chapter3-2. 디자인 패턴과 함수형 프로그래밍 그리고 상태 관리 설계 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimfriendship
wants to merge
43
commits into
hanghae-plus:main
Choose a base branch
from
kimfriendship:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제의 핵심취지
과제에서 꼭 알아가길 바라는 점
기본과제
심화과제
과제 셀프회고
깃헙 페이지 링크
요랬는데

요래 됐습니다~

과제를 하면서 내가 알게된 점, 좋았던 점은 무엇인가요?
알게된 점:
좋았던 점:
이번 과제에서 내가 제일 신경 쓴 부분은 무엇인가요?
도메인 계층 분리와 의존성 방향이 가장 신경 쓴 부분인 것 같아요:
completeOrder->onPurchase)이번 과제를 통해 앞으로 해보고 싶은게 있다면 알려주세요!
리뷰 받고 싶은 내용이나 궁금한 것에 대한 질문 편하게 남겨주세요 :)
멘토링 시간에 리팩토링을 할 때 왜 리팩토링을 하고 싶은지, 코드 스멜이 나는 이유는 무엇인지 스스로 생각해보고 시작하라고 하셨던 말씀이 도움이 많이 되었습니다. 감사합니다!