Bump to crystal 0.31.1 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a default preamble which enables fail fast mode in specs. Between crystal 0.30.1 and 0.31.0 this changed the output. The new crystal doesnt print a summary anymore, which means we will not find "Finished" in it. Instead only one "F" is printed and that's it (if there is exactly one test which fails). See also crystal-lang/crystal#8359
|
There is a bad bug in crystal meaning that even failed specs will not cause the exit code to be 1. See crystal-lang/crystal#8420 |
hanneskaeufler
force-pushed
the
hk-crystal-0.31.1
branch
2 times, most recently
from
27e92ae to
77c089e
Compare
fail fast mode alltogether. There is another bug in crystal which makes the fail fast mode entirely unusable for crystal.
hanneskaeufler
force-pushed
the
hk-crystal-0.31.1
branch
from
77c089e to
9f1d89e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work just fine