Hk crystal bump

.circleci/config.yml

@@ -3,10 +3,10 @@ version: 2
 jobs:
   test-crystal: &test-template
     docker:
-      - image: crystallang/crystal:1.3.2
+      - image: crystallang/crystal:1.4.0
     steps:
       - checkout
-  test-crystal-1.3.2:
+  test-crystal-1.4.0:
     <<: *test-template
     steps:
       - checkout
@@ -29,7 +29,7 @@ workflows:
   version: 2
   ci:
     jobs:
-      - test-crystal-1.3.2
+      - test-crystal-1.4.0
   nightly:
     triggers:
       - schedule:
@@ -38,4 +38,4 @@ workflows:
             branches:
               only: master
     jobs:
-      - test-crystal-1.3.2
+      - test-crystal-1.4.0

CHANGELOG.md

@@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- Support for crystal `1.2.2`
+- Support for crystal `1.4.0`. Fixed a bug where the `NumberLiteralSignFlip` mutant would apply to unsigned integers
 
 ## [8.0.0] - 2021-09-03
 

Makefile

@@ -1,6 +1,6 @@
 SHARDS_BIN ?= $(shell which shards)
 SHARD_BIN ?= ../../bin
-CRYSTAL_VERSION ?= 1.3.2
+CRYSTAL_VERSION ?= 1.4.0
 
 build: bin/crytic
 bin/crytic:

shard.yml

@@ -18,4 +18,4 @@ scripts:
 development_dependencies:
   ameba:
     github: veelenga/ameba
-    version: ~> 0.13
+    version: ~> 1.0

spec/mutant/number_literal_sign_flip_possibilities_spec.cr

@@ -27,7 +27,7 @@ module Crytic
     end
 
     it "doesn't consider unsigned integer types" do
-      ast = ast_from("1_u8; 1_u16; 1_u32; 1_u64;")
+      ast = ast_from("1_u8; 1_u16; 1_u32; 1_u64; 1_u128;")
       possibilities = Mutant::NumberLiteralSignFlipPossibilities.new
       ast.accept(possibilities)
       possibilities.empty?.should be_true

src/crytic/mutant/number_literal_sign_flip_possibilities.cr

@@ -14,13 +14,7 @@ module Crytic::Mutant
     end
 
     private def is_unsigned_type(node)
-      node.kind
-      case node.kind
-      when :u8, :u16, :u32, :u64
-        true
-      else
-        false
-      end
+      node.kind.to_s.starts_with?("u")
     end
   end
 end