chore: deprecate "userPropertyString" in favor of "saveUserProperty"

README.md

@@ -96,7 +96,7 @@ have the same parameters. Up to 500 event names are supported.
 Make sure to check the [Log Events](https://firebase.google.com/docs/analytics/android/events) docs to validate
   that you are using a valid event name (1st parameter) and parameter structure (2nd event).
 
-##### `setUserPropertyString(parameters)`
+##### `saveUserProperty(parameters)`
   - `parameters` (Dictionary)
     - `value` (String)
     - `name` (String)

android/src/firebase/analytics/TitaniumFirebaseAnalyticsModule.java

@@ -57,30 +57,31 @@ public void resetAnalyticsData()
 		this.analyticsInstance().resetAnalyticsData();
 	}
 
-	// clang-format off
 	@Kroll.method
 	@Kroll.setProperty
 	public void setEnabled(Boolean enabled)
-	// clang-format on
 	{
 		this.analyticsInstance().setAnalyticsCollectionEnabled(enabled);
 	}
 
-	// clang-format off
 	@Kroll.method
 	@Kroll.setProperty
 	public void setUserPropertyString(KrollDict parameters)
-	// clang-format on
+	{
+		Log.w(LCAT, "The \"userPropertyString\" property is deprecated in favor of the \"saveUserProperty({ name: '...', value: '...'})\" method!");
+		this.saveUserProperty(parameters);
+	}
+
+	@Kroll.method
+	public void saveUserProperty(KrollDict parameters)
 	{
 		this.analyticsInstance().setUserProperty(TiConvert.toString(parameters, "name"),
-												 TiConvert.toString(parameters, "value"));
+				TiConvert.toString(parameters, "value"));
 	}
 
-	// clang-format off
 	@Kroll.method
 	@Kroll.setProperty
 	public void setUserID(String id)
-	// clang-format on
 	{
 		this.analyticsInstance().setUserId(id);
 	}
@@ -99,11 +100,9 @@ public void fetchInstallationID(KrollFunction callback) {
 		});
 	}
 
-	// clang-format off
 	@Kroll.method
 	@Kroll.setProperty
 	public void setScreenNameAndScreenClass(KrollDict parameters)
-	// clang-format on
 	{
 		if (!parameters.containsKey("screenName")) {
 			Log.e(LCAT, "Unable to set current screen without the missing \"screenName\" key");

ios/Classes/FirebaseAnalyticsModule.h

@@ -11,7 +11,9 @@
 
 - (void)log:(id)arguments;
 
-- (void)setUserPropertyString:(id)arguments;
+- (void)saveUserProperty:(id)arguments;
+
+- (void)setUserPropertyString:(id)arguments; // DEPRECATED: Use "saveUserProperty(arguments)" method instead
 
 - (void)setUserID:(NSString *)userID;
 

ios/Classes/FirebaseAnalyticsModule.m

@@ -51,6 +51,12 @@ - (void)log:(id)arguments
 }
 
 - (void)setUserPropertyString:(id)arguments
+{
+  DEPRECATED_REPLACED(@"userPropertyString", @"5.1.0", @"saveUserProperty({ name: '...', value: '...' })");
+  [self saveUserProperty:arguments];
+}
+
+- (void)saveUserProperty:(id)arguments
 {
   ENSURE_SINGLE_ARG(arguments, NSDictionary);
 

ios/manifest

@@ -2,7 +2,7 @@
 # this is your module manifest and used by Titanium
 # during compilation, packaging, distribution, etc.
 #
-version: 5.0.0
+version: 5.1.0
 apiversion: 2
 architectures: arm64 x86_64
 description: titanium-firebase-analytics