Skip to content

Tiny type narrowing #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 21, 2022
Merged

Tiny type narrowing #1464

merged 6 commits into from
Dec 21, 2022

Conversation

felixdivo
Copy link
Collaborator

@felixdivo felixdivo commented Dec 21, 2022 •
edited
Loading

  • Slightly narrows the type of can.interfaces.BACKENDS from Dict[str, Tuple[str, ...]] to Dict[str, Tuple[str, str]]
  • Will behave more robust if too many : are given in entry-point declaration

@felixdivo felixdivo added this to the Next Release milestone Dec 21, 2022
@felixdivo felixdivo self-assigned this Dec 21, 2022
felixdivo and others added 4 commits December 21, 2022 16:37
@felixdivo
Copy link
Collaborator Author

Wow, the official documentation on that module is so bad ... I'll merge this with #1465 and do it as one. It's more changes than expected.

@felixdivo felixdivo changed the base branch from develop to felixdivo-patch-2 December 21, 2022 16:22
@felixdivo felixdivo merged commit db0a22b into felixdivo-patch-2 Dec 21, 2022
@mergify mergify bot deleted the felixdivo-patch-1 branch December 21, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@felixdivo felixdivo

Labels

minor work-in-progress

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

1 participant

@felixdivo