Skip to content

Add deprecation period to deprecated_args_alias #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

Add deprecation period to deprecated_args_alias #1477

merged 1 commit into from
Jan 5, 2023
+144 −21

Conversation

zariiii9003
Copy link
Collaborator

I added two parameters to deprecated_args_alias so the warning looks like this:

The 'old_a' argument is deprecated since python-can v1.6.0, and scheduled for removal in python-can v3.4.0. Use 'a' instead.

@pierreluctg @felixdivo What do you think?

@felixdivo
Copy link
Collaborator

I didn't check the code, but your proposal looks very good! 😃 🚀

I generally tried to waddle out of the responsibilities of this project though, so please understand that I don't have time to go through all changes each time. 🙃

@felixdivo felixdivo added this to the Next Release milestone Jan 5, 2023
@felixdivo felixdivo added docs QA about improving and maintaining the quality of the library labels Jan 5, 2023
@felixdivo felixdivo requested a review from pierreluctg January 5, 2023 10:26
hardbyte
hardbyte approved these changes Jan 5, 2023
View reviewed changes
Copy link
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, much nicer messages for users. Impressive testing too!

@hardbyte hardbyte merged commit 5e5b950 into hardbyte:develop Jan 5, 2023
@zariiii9003 zariiii9003 deleted the deprecation_period branch April 2, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardbyte hardbyte hardbyte approved these changes

@pierreluctg pierreluctg pierreluctg approved these changes

Assignees

@zariiii9003 zariiii9003

Labels
docs QA about improving and maintaining the quality of the library
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
4 participants
@zariiii9003 @felixdivo @hardbyte @pierreluctg