Extented slcan.py to use "L" command optional to "O" command. #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixdivo
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Nice change, but I'd suggest using BusState to be more consitent. See this example on how to parse it:
python-can/can/interfaces/pcan/pcan.py
Lines 248 to 251 in 5c523ec
|
ping @wolfraven -- unaddressed requested changes. |
Added additional parameter "listen_only" to open interface/channel with "L" command (in opposite to "O" command).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional parameter "listen_only" to open interface/channel with "L" command (in opposite to "O" command).