Skip to content

Allow wrapt 2.x #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Allow wrapt 2.x #1980

merged 1 commit into from
Aug 12, 2025

Conversation

musicinmybrain
Copy link
Contributor

Summary of Changes

  • Widened the version bound on the wrapt dependency to allow 2.x

Related Issues / Pull Requests

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe): dependency update

Checklist

  • I have followed the contribution guide.
  • I have added or updated tests as appropriate. N/A
  • I have added or updated documentation as appropriate. N/A
  • I have added a news fragment for towncrier.
  • All checks and tests pass (tox).

Additional Notes

This is based on testing with wrapt 2.0.0rc1, https://github.com/GrahamDumpleton/wrapt/blob/2.0.0rc1/docs/changes.rst.

$ uv venv
$ . .venv/bin/activate
(python-can) $ uv sync
(python-can) $ uv pip install -e .[canalystii,mf4,multicast,pywin32,serial,viewer]
(python-can) $ pytest -v
[everything succeeds]
(python-can) $ uv pip install wrapt==2.0.0rc1
[everything still succeeds]

I maintain the python-wrapt package in Fedora, and this PR is part of my work to make sure that I am ready to ship wrapt 2.0.0 in Rawhide, the development version of Fedora, as soon as 2.0.0 final is released.

@zariiii9003
Copy link
Collaborator

Looks good to me. Please add a changelog fragment if you expect a patch release, otherwise i can just merge into main.

@musicinmybrain
Copy link
Contributor Author

Looks good to me. Please add a changelog fragment if you expect a patch release, otherwise i can just merge into main.

I don’t personally have a particular need for a patch release. It’s easy enough to carry this downstream until the next regular release. Thanks!

@zariiii9003 zariiii9003 merged commit bc248e8 into hardbyte:main Aug 12, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants