Skip to content

Keep a reference to asyncio tasks #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Keep a reference to asyncio tasks #1982

merged 1 commit into from
Aug 19, 2025

Conversation

zariiii9003
Copy link
Collaborator

Summary of Changes

In can.Notifier._on_message_received() save a reference of each created asyncio.Task into a set and automatically discard it once it is fnished.

Related Issues / Pull Requests

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe):

Checklist

  • I have followed the contribution guide.
  • I have added or updated tests as appropriate.
  • I have added or updated documentation as appropriate.
  • I have added a news fragment for towncrier.
  • All checks and tests pass (tox).

Additional Notes

@zariiii9003 zariiii9003 merged commit 921b47e into hardbyte:main Aug 19, 2025
29 of 31 checks passed
@zariiii9003 zariiii9003 deleted the task-ref branch August 19, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async callbacks tasks is not kept and might be GC before the callback is run
1 participant
@zariiii9003