Better AOT testing - #13
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 21948101068Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Mozilla nightly downloads now use xz compression. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace reflection-based JsonSerializer.Serialize with a simple FormatJsValue helper for Firefox user_pref() values. The preference values are only primitives (string, bool, int) so full JSON serialization is unnecessary and breaks under PublishAot=true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix AOT-incompatible JsonSerializer calls in ChromiumTransport by replacing them with Utf8JsonWriter-based serialization. Add browser selection (firefox/chrome) CLI argument to the smoke test, and add a Chrome integration test alongside the existing Firefox one. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kblok
added a commit
that referenced
this pull request
Feb 12, 2026
* Better AOT testing * add integration test * install firefox * download firefox manually * Fix Firefox Nightly download: use tar.xz instead of tar.bz2 Mozilla nightly downloads now use xz compression. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix AOT crash in FirefoxLauncher.CreateProfile Replace reflection-based JsonSerializer.Serialize with a simple FormatJsValue helper for Firefox user_pref() values. The preference values are only primitives (string, bool, int) so full JSON serialization is unnecessary and breaks under PublishAot=true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add Chrome support to AOT smoke test Fix AOT-incompatible JsonSerializer calls in ChromiumTransport by replacing them with Utf8JsonWriter-based serialization. Add browser selection (firefox/chrome) CLI argument to the smoke test, and add a Chrome integration test alongside the existing Firefox one. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's test this for real