Fluffy my sky login #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harej
requested changes
Nov 20, 2021
There was a problem hiding this comment.
The Math.random thing is the only hard stop I can see here. I do have a question though: will there also be a utility to help SkyID users transition their content to MySky? Since you submitted this pull request to the main branch, on deployment it will replace the current (SkyID-based) Hacker Paste and without communication around this it could be very disruptive.
| clickListener("button-username", loadMyPastes); | ||
| MicroModal.close('app-modal'); | ||
| } else { | ||
| let defaultContent = {documents:[{label: "Note to Self", docID:Math.random()*1000}]} |
There was a problem hiding this comment.
I do not recommend using Math.random for generating randomness since random number generators are used in Hacker Paste in a security-sensitive context (i.e. decryption keys).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the mysky implementation in place of skyid