Repository navigation
Bind hb_ot_tags_from_script_and_language() and hb_ot_tags_to_script_and_language() - #235
Merged
Merged
Conversation
lianghai
marked this pull request as ready for review
October 4, 2026 20:54
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #234.
See also: https://harfbuzz.github.io/harfbuzz-hb-ot-layout.html.
Notes:
hb_ot_tags_from_script_and_language()’slanguageparameter. The optionality of other (in)out parameters doesn’t seem that relevant to the JS binding.language_from_string()can be used here forhb_ot_tags_from_script_and_language()’slanguageparameter? But a parallel function for script doesn’t exist, so I followedBuffer.setLanguage()and.setScript()’s parallel logic instead.hb_ot_tags_from_script_and_language()actually produces multiple language tags. Added a few typical cases for testing.it()can be the tested function itself, so the function’s name is used, which may be more maintainable when there isn’t much to say about a test. Also an arrow function as the second argument may be less cluttering?