Repository navigation
capi: support batched nominal glyph callbacks - #509
Merged
Merged
Conversation
Support Skia face setup and callback-backed table enumeration. Keep collection selection separate from mutable face index metadata. Assisted-by: OpenAI Codex
Map strided batches in public queries and shaping, with scalar/batch fallback and callback precedence through subfonts. Assisted-by: OpenAI Codex
6 tasks
dfrg
approved these changes
Oct 8, 2026
) * Format face regression tests * Format batch regression tests * capi: report HarfBuzz compatibility version and split OpenType aliases Keep the package version unchanged while making hb_version and HB_VERSION aliases report the matched shaping release. Add hr-hb-ot.h and generate portable include guards. Assisted-by: OpenAI Codex
…minal-glyphs # Conflicts: # harfrust_capi/src/lib.rs
…api/skia-nominal-glyphs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skia installs
hb_font_funcs_set_nominal_glyphs_funcwhen the HarfBuzz version enables batched mapping. Add its HarfRust counterpart,hr_font_get_nominal_glyphs, and source aliases; use the batch callback during shaping as well as public queries.Preserve byte strides, zero strides, partial results, scalar/batch fallback, and subfont precedence. A child's scalar callback takes precedence over a parent's batch callback.
Validation: 134 C API tests pass and Clippy passes with warnings denied. Regression tests exercise strided and partial batches, scalar fallback, zero-length calls, shaping through the batch callback, and parent/child precedence.
Stacked on #508; part of #507.