Repository navigation
subset capi: expose configurable input sets, flags, and preprocessing - #512
Merged
Merged
Conversation
Support Skia face setup and callback-backed table enumeration. Keep collection selection separate from mutable face index metadata. Assisted-by: OpenAI Codex
Map strided batches in public queries and shaping, with scalar/batch fallback and callback precedence through subfonts. Assisted-by: OpenAI Codex
Keep the package version unchanged while making hb_version and HB_VERSION aliases report the matched shaping release. Add hr-hb-ot.h and generate portable include guards. Assisted-by: OpenAI Codex
Provide Skia glyph/Unicode selection, retained IDs, notdef outlines, and hint removal through hr_subset APIs and hr-hb-subset.h. Import the core C ABI instead of embedding a second shaping library. Assisted-by: OpenAI Codex
Add configurable name/layout/drop sets, keep-everything, and supported Skera flags. Preserve inverted tag sets and return an owned immutable preprocessing face. Assisted-by: OpenAI Codex
This was referenced Oct 7, 2026
…bset # Conflicts: # harfrust_capi/README.md
behdad
added this pull request to stack #518
October 8, 2026 06:10
7 of 12 tasks
dfrg
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the subset C API beyond Skia's initial glyph workflow with
hr_subset_input_set,hr_subset_input_keep_everything, andhr_subset_preprocess, plus HarfBuzz aliases. Expose configurable names/languages, layout features/scripts, and dropped-table sets, along with the implemented Skera flags for legacy names, overlap bits, unknown-table passthrough, glyph names, Unicode ranges, layout closure, and bidi closure.These APIs are part of the optional
subsetfeature ofharfrust_capi; enable it withcargo build -p harfrust_capi --features subsetand link the singleharfrust_clibrary. Headers, examples, and tests live underharfrust_capi.Preserve inverted input tag sets when building Skera plans. Skera uses that representation to select existing script records efficiently; materializing all possible tags would make it enumerate billions of values. Preprocessing returns an immutable standalone face owning copied tables, without promising an acceleration cache.
Published Skera fixes its no-subset-table set internally, so modifying that set currently returns failure rather than ignoring the request. A small upstream Plan API extension is being prepared for customization and glyph mappings. Axis instancing, CFF/CFF2/VARC, and unimplemented dependency flags remain unavailable.
Validation: the original 48 differential cases and 15 additional HarfBuzz comparisons pass, including input-set defaults, keep-everything, name/layout/drop controls, all added flags, unknown tables, overlap bits, and preprocessing ownership. Rust 1.85 checking, rustfmt, and Clippy pass. The CI C smoke test now also exercises preprocessing, inverted selections, and subsequent customization.
Stacked on #511; extends #507.