Repository navigation
Fix test_set_axis_range failure due to test data type mismatch - #279
Merged
Merged
Conversation
The set_axis_range Cython method declares def_value as float|None, which in Cython does not accept int. Two test parametrizations passed int literals (100, 300) instead of floats (100.0, 300.0), causing TypeError in unit tests. The patch edits the test data to properly feed float values. This patch closes: harfbuzz#278
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
set_axis_rangeCython method declaresdef_valueasfloat|None, which in Cython does not acceptint. Two test parametrizations passed int literals(100, 300)instead of floats(100.0, 300.0), causing TypeError in unit tests. The patch edits the test data to properly feed float values during unit tests.This patch closes: #278