Skip to content

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented Sep 8, 2025

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: Adds the output file schema for sending impressions from FME to S3. Conversation with Agus on Slack.
  • Jira/GitHub Issue numbers (if any): https://harness.atlassian.net/browse/FMEPRD-281
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@alai97 alai97 requested a review from rpierce99 September 8, 2025 21:05
Copy link

@rpierce99 rpierce99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nitpick would be "File restrictions" since we're the ones putting the files in the bucket, there is probably a better description of the section

Copy link
Collaborator

@dtk-DaveKarow dtk-DaveKarow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68bf476d98e337cd57349a1a--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68bf4814f99df5c74b1d9468--harness-developer.netlify.app

@alai97 alai97 merged commit 47bec1b into main Sep 12, 2025
4 checks passed
@alai97 alai97 deleted the fme-s3-integration-doc-update branch September 12, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants