Patch Setting.ui_theme class method#16
Open
alessandro-fazzi wants to merge 1 commit into
Open
Conversation
alessandro-fazzi
force-pushed
the
patch_setting_ui_theme
branch
from
0e03b7b to
70cb8c2
Compare
Now the method returns the theme set in user settings through plugin's additional config. If the user hasn't set a custom theme, then it fallback to what is the core implementation. The major effect obtained is to have the right class names produced by ApplicationHelper#css_body_classes, thus not breaking the css targeting a specific theme using body's classes.
alessandro-fazzi
force-pushed
the
patch_setting_ui_theme
branch
from
70cb8c2 to
b424570
Compare
Codecov Report
@@ Coverage Diff @@
## develop #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 17 17
=========================================
Hits 17 17 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the method returns the theme set in user
settings through plugin's additional config.
If the user hasn't set a custom theme, then
it fallback to what is the core implementation.
The major effect obtained is to have the right
class names produced by
ApplicationHelper#css_body_classes, thus not
breaking the css targeting a specific theme
using body's classes.