Skip to content

Fix ffq fallback for SRA downloads#305

Merged
tsackton merged 2 commits into
mainfrom
codex/fix-sra-bug
Apr 6, 2026
Merged

Fix ffq fallback for SRA downloads#305
tsackton merged 2 commits into
mainfrom
codex/fix-sra-bug

Conversation

@tsackton
Copy link
Copy Markdown
Contributor

@tsackton tsackton commented Apr 6, 2026

Summary

  • replace the broken ffq --ftp xargs fallback in download_sra with a real shell loop
  • log each ENA URL before downloading and send curl output into the Snakemake log
  • add a dry-run regression assertion that the rendered SRA download command uses the looped fallback
  • roll back sra-tools to 3.2.1 to fix segfaults

Testing

  • pytest -q tests/tests.py -k mixed_srr_and_fastq_same_sample_dry_run

@tsackton tsackton merged commit 70bf1b5 into main Apr 6, 2026
13 checks passed
@tsackton tsackton deleted the codex/fix-sra-bug branch April 6, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant