Skip to content

Patch HCP Consul/HCP Vault tutorial#74

Draft
webdog wants to merge 10 commits into
mainfrom
webdog/patch/hcp-consul-hcp-vault
Draft

Patch HCP Consul/HCP Vault tutorial#74
webdog wants to merge 10 commits into
mainfrom
webdog/patch/hcp-consul-hcp-vault

Conversation

@webdog

@webdog webdog commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

There were some blockers that prevent successful deployment:

  • Unique names were not enforced
  • kubeconfig generation wasn't consistent
  • kube cluster context wasn't set right

Added:

  • programmatic generation of consul-values
  • makefile for easier deployment

@hashicorp-cla

hashicorp-cla commented Aug 26, 2022

Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


0 out of 2 committers have signed the CLA.

  • Christian Weber
  • webdog

Christian Weber seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

}
volume_mount {
mount_path = "/root/consul-values.yaml"
name = "consul-values.yaml"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "consul-values.yaml"
name = "consul-values"

}
}
volume {
name = "consul-values.yaml"

@lamadome lamadome Aug 31, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "consul-values.yaml"
name = "consul-values"

Name is not valid. TF is throwing an error when running this.

Comment thread hcp-consul-hcp-vault-ca/confirm.sh Outdated
@@ -0,0 +1,32 @@
#!/usr/bin/env bash
export WORKBENCH=$(kubectl get pods -l app=tutorial -o json | jq -r ".items[0].metadata.name")
rc =$(echo $?)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rc =$(echo $?)
rc=$(echo $?)

Space after the variable name generates error

@webdog webdog force-pushed the webdog/patch/hcp-consul-hcp-vault branch from 2c76221 to 61657ff Compare September 1, 2022 23:30
@webdog webdog closed this Nov 23, 2022
@im2nguyen im2nguyen reopened this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants