-
Notifications
You must be signed in to change notification settings - Fork 49
Button, Project Solar - focus style updates (HDS-5666)
#3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: project-solar/phase-1-main-feature-branch
Are you sure you want to change the base?
Button, Project Solar - focus style updates (HDS-5666)
#3388
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Button focus style updates (HDS-5666)Button, Project Solar Dryrun - focus style updates (HDS-5666)
50bed6b to
0db2121
Compare
Button, Project Solar Dryrun - focus style updates (HDS-5666)Button, Project Solar - focus style updates (HDS-5666)
This comment was marked as resolved.
This comment was marked as resolved.
6e213a8 to
b69f52a
Compare
|
Added back test of focus styles using |
62f73a0 to
6e3d58b
Compare
8706f95 to
7b70bad
Compare
| box-shadow: var(--token-elevation-low-box-shadow); | ||
| } | ||
|
|
||
| // Use pseudo element for focus ring to allow offset position to be partially inside the button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of pseudo-elements for focus on AdvancedTable child components can be re-examined at a later time, as it seems to necessitate visual design changes.
6e3d58b to
2e4a003
Compare
ddad66b to
76f867b
Compare
cb62d03 to
59aacb2
Compare
…dow closer to Carbon Button style implementation
…Table for now overriding outline style
…onItem, refactor dark-themed nav interactive elements to use outline
6f86f64 to
6b42070
Compare
WIP: Testing modifications to
Buttonfocus styles to standardize and to optimize for easier "Carbonization"Previews:
📌 Summary
If merged, this PR modifies the focus styles of Buttons...
🛠️ Detailed description
📸 Screenshots
PROPOSED STANDARDIZATION OF “PRIMARY” FOCUS STYLE
CURRENT FOCUS STYLE

STANDARDIZED FOCUS STYLE

Modified to follow styling of other
Buttonvariant focus styles🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.