Fixed a bug when Retry-After is 0, it should use min wait time.

client.go

@@ -512,7 +512,11 @@ func DefaultBackoff(min, max time.Duration, attemptNum int, resp *http.Response)
 		if resp.StatusCode == http.StatusTooManyRequests || resp.StatusCode == http.StatusServiceUnavailable {
 			if s, ok := resp.Header["Retry-After"]; ok {
 				if sleep, err := strconv.ParseInt(s[0], 10, 64); err == nil {
-					return time.Second * time.Duration(sleep)
+					if sleep > 0 {
+						return time.Second * time.Duration(sleep)
+					} else {
+						return min
+					}
 				}
 			}
 		}

client_test.go

@@ -640,37 +640,45 @@ func TestClient_CheckRetry(t *testing.T) {
 
 func TestClient_DefaultBackoff(t *testing.T) {
 	for _, code := range []int{http.StatusTooManyRequests, http.StatusServiceUnavailable} {
-		t.Run(fmt.Sprintf("http_%d", code), func(t *testing.T) {
-			ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-				w.Header().Set("Retry-After", "2")
-				http.Error(w, fmt.Sprintf("test_%d_body", code), code)
-			}))
-			defer ts.Close()
-
-			client := NewClient()
-
-			var retryAfter time.Duration
-			retryable := false
-
-			client.CheckRetry = func(_ context.Context, resp *http.Response, err error) (bool, error) {
-				retryable, _ = DefaultRetryPolicy(context.Background(), resp, err)
-				retryAfter = DefaultBackoff(client.RetryWaitMin, client.RetryWaitMax, 1, resp)
-				return false, nil
-			}
+		for _, responseRetryAfter := range []string{"0", "2"} {
+			t.Run(fmt.Sprintf("http_%d", code), func(t *testing.T) {
+				ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+					w.Header().Set("Retry-After", responseRetryAfter)
+					http.Error(w, fmt.Sprintf("test_%d_body", code), code)
+				}))
+				defer ts.Close()
+
+				client := NewClient()
+
+				var retryAfter time.Duration
+				retryable := false
+
+				client.CheckRetry = func(_ context.Context, resp *http.Response, err error) (bool, error) {
+					retryable, _ = DefaultRetryPolicy(context.Background(), resp, err)
+					retryAfter = DefaultBackoff(client.RetryWaitMin, client.RetryWaitMax, 1, resp)
+					return false, nil
+				}
 
-			_, err := client.Get(ts.URL)
-			if err != nil {
-				t.Fatalf("expected no errors since retryable")
-			}
+				_, err := client.Get(ts.URL)
+				if err != nil {
+					t.Fatalf("expected no errors since retryable")
+				}
 
-			if !retryable {
-				t.Fatal("Since the error is recoverable, the default policy shall return true")
-			}
+				if !retryable {
+					t.Fatal("Since the error is recoverable, the default policy shall return true")
+				}
 
-			if retryAfter != 2*time.Second {
-				t.Fatalf("The header Retry-After specified 2 seconds, and shall not be %d seconds", retryAfter/time.Second)
-			}
-		})
+				if responseRetryAfter == "0" {
+					if retryAfter != client.RetryWaitMin {
+						t.Fatalf("The header Retry-After specified %d seconds, and shall not be %d seconds", client.RetryWaitMin/time.Second, retryAfter/time.Second)
+					}
+				} else {
+					if retryAfter != 2*time.Second {
+						t.Fatalf("The header Retry-After specified 2 seconds, and shall not be %d seconds", retryAfter/time.Second)
+					}
+				}
+			})
+		}
 	}
 }