Skip to content

Conversation

edwin-Marrima
Copy link

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 12, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


0 out of 2 committers have signed the CLA.

  • Edwin Marrima
  • edwin-Marrima

Edwin Marrima seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @edwin-Marrima
Could you describe a use case for comparing constraints?
Is this just for displaying constraints somewhere in a UI?

I mean, it's clear how to sort versions but how could we sort the operators? That looks like a very subjective and context-dependent problem. I can see you attempted to do that but it seems a bit arbitrary to decide that one operator is "less" than the other.

What might be a reasonable compromise is to expose the parsed version via a hypothetical Version() method of a Constraint, what do you think about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants