Skip to content

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Sep 24, 2025

Description

resolve: #26801

While migrating to pnpm which has much stricter dependancies resolution rules we missed a couple of deps that needs to be explicitly installed such as one that broke flyout component @ember/test-helpers

Testing & Reproduction steps

Links

NMD-1004

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@jrasell
Copy link
Member

jrasell commented Oct 3, 2025

Hi @aklkv and thanks for raising this. Are you able to take a look into the failing tests please?

@aklkv
Copy link
Contributor Author

aklkv commented Oct 3, 2025

@jrasell I have, and consulted with @philrenaud and it seems to be known flaky test

@philrenaud
Copy link
Contributor

Confirming that it's flakey but eventually passes on rerun, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Nomad UI action fly-out doesn't show properly
3 participants