Skip to content

Conversation

@gizmo-rt
Copy link

Motivation
#11875 (comment)

Tests
image

Closes #11875

@gizmo-rt gizmo-rt requested a review from a team as a code owner March 29, 2025 19:45
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Mar 29, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@gizmo-rt gizmo-rt force-pushed the feat/password_data_source branch from 88200b3 to 5cde618 Compare May 6, 2025 19:39
@anshulsharma-hashicorp
Copy link
Contributor

@gizmo-rt now this looks better, one last thing for all the datasource we have in packer we have a doc page as well, which explains that datasource use-case and required fields etc. for this please go through the http datasource https://github.com/hashicorp/packer/blob/main/website/content/docs/datasources/http.mdx?plain=1 and it's equivalent doc on web https://developer.hashicorp.com/packer/docs/datasources/http. Please add this into your same PR.

@gizmo-rt gizmo-rt requested a review from a team as a code owner May 7, 2025 17:12
@anshulsharma-hashicorp
Copy link
Contributor

anshulsharma-hashicorp commented May 8, 2025

📄 Content Checks

Updated: Wed, 07 May 2025 17:12:54 GMT

Found 4 error(s)

@gizmo-rt could you please fix above mentioned 4 errors

@gizmo-rt gizmo-rt requested a review from anurag5sh May 8, 2025 14:04
@anurag5sh anurag5sh dismissed their stale review May 13, 2025 05:31

Changes done.

Copy link
Contributor

@anshulsharma-hashicorp anshulsharma-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshulsharma-hashicorp anshulsharma-hashicorp self-requested a review May 14, 2025 02:45
Copy link
Contributor

@anshulsharma-hashicorp anshulsharma-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vercel permission we need to check.

Also your imports are not in correct order in following files due to which lint check is breaking please check this
datasource/password/data.go:9
datasource/password/utility.go:9
@gizmo-rt

@gizmo-rt
Copy link
Author

gizmo-rt commented Jun 2, 2025

@anshulsharma-hashicorp What is the plan to move this to main ?

@gizmo-rt
Copy link
Author

@kp2099 @anurag5sh ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support to Generate Passwords

3 participants