-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: adds support to generate passwords #13344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
88200b3 to
5cde618
Compare
|
@gizmo-rt now this looks better, one last thing for all the datasource we have in packer we have a doc page as well, which explains that datasource use-case and required fields etc. for this please go through the http datasource https://github.com/hashicorp/packer/blob/main/website/content/docs/datasources/http.mdx?plain=1 and it's equivalent doc on web https://developer.hashicorp.com/packer/docs/datasources/http. Please add this into your same PR. |
@gizmo-rt could you please fix above mentioned 4 errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vercel permission we need to check.
Also your imports are not in correct order in following files due to which lint check is breaking please check this
datasource/password/data.go:9
datasource/password/utility.go:9
@gizmo-rt
|
@anshulsharma-hashicorp What is the plan to move this to main ? |
Motivation
#11875 (comment)
Tests

Closes #11875