azurerm_container_app_environment: fix infrastructure_resource_group_name behavior with workload_profile set to Consumption
#27502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name behavior with consumption workload profile
J0F3
reviewed
Sep 26, 2024
| workload_profile_type = "Consumption" | ||
| } | ||
|
|
||
| zone_redundancy_enabled = true |
There was a problem hiding this comment.
When here the intention is to test the configuration with infrastructure_subnet_id and workload_profile only I think zone_redundancy_enabled should be not be part of this test resource as it may have other implications.
J0F3
reviewed
Sep 26, 2024
| @@ -103,13 +103,9 @@ func (r ContainerAppEnvironmentResource) Arguments() map[string]*pluginsdk.Schem | |||
| RequiredWith: []string{"workload_profile"}, | |||
| ValidateFunc: resourcegroups.ValidateName, | |||
| DiffSuppressOnRefresh: true, | |||
| DiffSuppressFunc: func(k, oldValue, newValue string, d *pluginsdk.ResourceData) bool { // If this is omitted, and there is a non-consumption profile, then the service generates a value for the required manage resource group. | |||
| DiffSuppressFunc: func(k, oldValue, newValue string, d *pluginsdk.ResourceData) bool { // If this is omitted, then the service generates a value for the required manage resource group. | |||
There was a problem hiding this comment.
Suggested change
| DiffSuppressFunc: func(k, oldValue, newValue string, d *pluginsdk.ResourceData) bool { // If this is omitted, then the service generates a value for the required manage resource group. | |
| DiffSuppressFunc: func(k, oldValue, newValue string, d *pluginsdk.ResourceData) bool { // If this is omitted and workload_profile is set, then the service generates a value for the required manage resource group. |
Maybe?
There was a problem hiding this comment.
Make sense, will add this line.
J0F3
reviewed
Sep 26, 2024
| return true | ||
| } | ||
| } | ||
| return true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
infrastructure_resource_group_namewill be generated by the service even withworkload_profileset toConsumption, this will cause unexpected changes in the state file.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_container_app_environment: fixinfrastructure_resource_group_namebehavior withworkload_profileset toConsumption[azurerm_container_app_environment with infrastructure_subnet_id set is not idempotent #27481]This is a (please select all that apply):
Related Issue(s)
Fixes #27481
Note
If this PR changes meaningfully during the course of review please update the title and description as required.