Resource - azurerm_log_analytics_workspace Fix: Allow for undeletion of LAW after attaching to Log Analytics Cluster
#27522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
requested changes
Sep 26, 2024
| } | ||
|
|
||
| if deletedModel := deletedResp.Model; deletedModel != nil { | ||
| for _, v := range *deletedModel.Value { |
There was a problem hiding this comment.
we will need to nil check value
|
|
||
| if deletedModel := deletedResp.Model; deletedModel != nil { | ||
| for _, v := range *deletedModel.Value { | ||
| if *v.Name == name && strings.EqualFold(string(v.Properties.Sku.Name), string(workspaces.WorkspaceSkuNameEnumLACluster)) { |
There was a problem hiding this comment.
and name + properties + sku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.