New Resource and Data Source: container_app_environment_managed_certificate
#28366
+768
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
stephybun
reviewed
Jan 30, 2025
| ManagedEnvironmentId string `tfschema:"container_app_environment_id"` | ||
| DomainControlValidation string `tfschema:"domain_control_validation_type"` | ||
| SubjectName string `tfschema:"subject_name"` | ||
| Tags map[string]interface{} `tfschema:"tags"` |
There was a problem hiding this comment.
Suggested change
| Tags map[string]interface{} `tfschema:"tags"` | |
| Tags map[string]string `tfschema:"tags"` |
|
|
||
| type ContainerAppEnvironmentManagedCertificateModel struct { | ||
| Name string `tfschema:"name"` | ||
| ManagedEnvironmentId string `tfschema:"container_app_environment_id"` |
There was a problem hiding this comment.
Could we rename this to
Suggested change
| ManagedEnvironmentId string `tfschema:"container_app_environment_id"` | |
| ContainerAppEnvironmentId string `tfschema:"container_app_environment_id"` |
|
|
||
| managedEnvironment, err := managedEnvironmentsClient.Get(ctx, *managedEnvironmentId) | ||
| if err != nil { | ||
| return fmt.Errorf("reading %s: %+v", *managedEnvironmentId, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("reading %s: %+v", *managedEnvironmentId, err) | |
| return fmt.Errorf("retrieving %s: %+v", *managedEnvironmentId, err) |
| return fmt.Errorf("reading %s: %+v", *managedEnvironmentId, err) | ||
| } | ||
|
|
||
| managedCertId := managedenvironments.NewManagedCertificateID(metadata.Client.Account.SubscriptionId, managedEnvironmentId.ResourceGroupName, managedEnvironmentId.ManagedEnvironmentName, cert.Name) |
There was a problem hiding this comment.
Suggested change
| managedCertId := managedenvironments.NewManagedCertificateID(metadata.Client.Account.SubscriptionId, managedEnvironmentId.ResourceGroupName, managedEnvironmentId.ManagedEnvironmentName, cert.Name) | |
| managedCertId := managedenvironments.NewManagedCertificateID(managedEnvironmentId.SubscriptionId, managedEnvironmentId.ResourceGroupName, managedEnvironmentId.ManagedEnvironmentName, cert.Name) |
| Location: managedEnvironment.Model.Location, | ||
| Name: pointer.To(managedCertId.ManagedCertificateName), | ||
| Properties: &managedenvironments.ManagedCertificateProperties{ | ||
| DomainControlValidation: &domainControlValidation, |
There was a problem hiding this comment.
Suggested change
| DomainControlValidation: &domainControlValidation, | |
| DomainControlValidation: pointer.To(managedenvironments.ManagedCertificateDomainControlValidation(cert.DomainControlValidation)), |
| } | ||
|
|
||
| func (r ContainerAppEnvironmentManagedCertificateResource) requiresImport(data acceptance.TestData) string { | ||
| template := r.basic(data) |
There was a problem hiding this comment.
Suggested change
| template := r.basic(data) |
|
|
||
| type ContainerAppEnvironmentManagedCertificateDataSourceModel struct { | ||
| Name string `tfschema:"name"` | ||
| ManagedEnvironmentId string `tfschema:"container_app_environment_id"` |
There was a problem hiding this comment.
Suggested change
| ManagedEnvironmentId string `tfschema:"container_app_environment_id"` | |
| ContainerAppEnvironmentId string `tfschema:"container_app_environment_id"` |
| // Read Only | ||
| SubjectName string `tfschema:"subject_name"` | ||
| DomainControlValidation string `tfschema:"domain_control_validation_type"` | ||
| Tags map[string]interface{} `tfschema:"tags"` |
There was a problem hiding this comment.
Suggested change
| Tags map[string]interface{} `tfschema:"tags"` | |
| Tags map[string]string `tfschema:"tags"` |
| if response.WasNotFound(existing.HttpResponse) { | ||
| return fmt.Errorf("%s was not found", id) | ||
| } | ||
| return fmt.Errorf("reading %s: %+v", id, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("reading %s: %+v", id, err) | |
| return fmt.Errorf("retrieving %s: %+v", id, err) |
| cert.ManagedEnvironmentId = envId.ID() | ||
|
|
||
| if model := existing.Model; model != nil { | ||
| cert.Tags = tags.Flatten(model.Tags) |
There was a problem hiding this comment.
Suggested change
| cert.Tags = tags.Flatten(model.Tags) | |
| cert.Tags = pointer.From(model.Tags) |
stephybun
reviewed
Jan 30, 2025
Comment on lines
+91
to
+94
| * `create` - (Defaults to 30 minutes) Used when creating the Container App Environment Managed Certificate. | ||
| * `update` - (Defaults to 30 minutes) Used when updating the Container App Environment Managed Certificate. | ||
| * `read` - (Defaults to 5 minutes) Used when retrieving the Container App Environment Managed Certificate. | ||
| * `delete` - (Defaults to 30 minutes) Used when deleting the Container App Environment Managed Certificate. |
There was a problem hiding this comment.
Suggested change
| * `create` - (Defaults to 30 minutes) Used when creating the Container App Environment Managed Certificate. | |
| * `update` - (Defaults to 30 minutes) Used when updating the Container App Environment Managed Certificate. | |
| * `read` - (Defaults to 5 minutes) Used when retrieving the Container App Environment Managed Certificate. | |
| * `delete` - (Defaults to 30 minutes) Used when deleting the Container App Environment Managed Certificate. | |
| * `create` - (Defaults to 30 minutes) Used when creating the Container App Environment Managed Certificate. | |
| * `read` - (Defaults to 5 minutes) Used when retrieving the Container App Environment Managed Certificate. | |
| * `update` - (Defaults to 30 minutes) Used when updating the Container App Environment Managed Certificate. | |
| * `delete` - (Defaults to 30 minutes) Used when deleting the Container App Environment Managed Certificate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
Add new data source and resource –
container_app_environment_managed_certificate.According to a comment here, a new bindingType option
bindingType: 'auto'will be introduced to thecustomDomainsproperty of thecontainerAppresource starting in mid-January 2025. This update will simplify the process by eliminating the current two-step approach, where both a binding and a managed certificate need to be created in specific order. With this change, only the managed certificate will need to be created. This PR adds the managed certificate resource to support this scenario.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
container_app_environment_managed_certificatecontainer_app_environment_managed_certificateThis is a (please select all that apply):
Related Issue(s)
Fixes #21866
Note
If this PR changes meaningfully during the course of review please update the title and description as required.