[BUG FIX] - Fixing bug that prevents postgresql_flexible_server_virtu…

[leonrob]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

I originally logged this bug here: #27796

But haven't received a response. So I figured I'd just fix it and see if you guys can work with what I send.

the Read function does not handle the scenario where the source server and replica server roles switch during a failover. This causes Terraform to interpret the resource as missing or changed, leading to an attempt to recreate it.

In the Read function:
The state.SourceServerId and state.ReplicaServerId are determined based on the response from the Azure API.
If a failover occurs, the source server and replica server may swap roles, but the Read function does not account for this role reversal.
Terraform detects this as a drift from the expected state and plans to recreate the resource.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27796

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[leonrob]

Attempting to fix bug #27796

if anyone sees this please let me know if this needs anything further

[leonrob]

anyone? anyone? :)

[katbyte]

Hey @leonrob - i've run CI on the PR and looks like there are a few things that need to be addressed

[leonrob]

Hey @katbyte - is it possible to have someone finish this up as I'm not sure what it needs. I threw this together as a starting point

[mbfrahry]

Hey @leonrob, thanks for getting this started! Is there any chance you could provide a series of steps to reproduce this? I saw in your issue that it's easy to do but I'm not very familiar with this resource so I'd appreciate any help I can get so I can play with the code you've given and make sure it's working as intended

[leonrob]

Hey @leonrob, thanks for getting this started! Is there any chance you could provide a series of steps to reproduce this? I saw in your issue that it's easy to do but I'm not very familiar with this resource so I'd appreciate any help I can get so I can play with the code you've given and make sure it's working as intended

Hey yes - what are you looking for? Would a chat conversation be easier by chance?