Resolve 4.0 TODOs Kusto

[wyattfry]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Rename old attributes for azurerm_kusto_attached_database_configuration and azurerm_kusto_eventgrid_data_connection resources

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

5.0 Mode

4.0 Mode

Image Forthcoming

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_kusto_attached_database_configuration - replace cluster_resource_id with cluster_id [Resolve 4.0 TODOs Kusto #28530]
• azurerm_kusto_eventgrid_data_connection - replace eventgrid_resource_id with eventgrid_event_subscription_id and managed_identity_resource_id with managed_identity_id [Resolve 4.0 TODOs Kusto #28530]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes (private issue)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[wyattfry]

TeamCity Tests deletes are timing out, OK otherwise

[mbfrahry]

Hey @wyattfry, these changes are nearly there. Just missed imports being off and we'll need to remove ForceNew from one of the deprecated attributes.

[mbfrahry]

Similar to what Steph said here, we'll have to remove ForceNew here as well for when people move from cluster_resource_id to cluster_id as cluster_resource_id will have to be removed which will cause ForceNew to trigger

[wyattfry]

ah i see, thanks!

[mbfrahry]

Hey @wyattfry, looks good but that pesky new line is still in one of the import blocks