Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerapps - fixup name validation regexes and extend validation testing #28625

Merged
merged 1 commit into from
Jan 30, 2025
Merged

containerapps - fixup name validation regexes and extend validation testing #28625

merged 1 commit into from
Jan 30, 2025
+21 −10

Conversation

jackofallops
Copy link
Member

No description provided.

@jackofallops jackofallops requested a review from a team as a code owner January 29, 2025 13:19
stephybun
stephybun approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops 🙉 🙈 🐒 LGTM

@stephybun stephybun added the bug label Jan 29, 2025
@jackofallops jackofallops mentioned this pull request Jan 30, 2025
Merged
@jackofallops jackofallops merged commit a389708 into main Jan 30, 2025
30 checks passed
@jackofallops jackofallops deleted the b/containerapp-names-validation-fixes branch January 30, 2025 14:51
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug service/container-apps size/S
Projects
None yet
Milestone
v4.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jackofallops @stephybun