Skip to content
This repository was archived by the owner on Dec 9, 2020. It is now read-only.

Conversation

@ychemerys
Copy link

PR with related changes to go-librato: https://github.com/henrikhodne/go-librato/pull/15

Please let me know what can I do to get this merged. Thanks.

@twall
Copy link

twall commented Sep 29, 2017

This looks great. I'm not sure if if belongs in this module, but it'd be useful to take a list of required tags as input. Cloudlock currently requires "Env" and "Billing", and it's highly likely Cisco will soon have at least one other tag requirement.

@radeksimko
Copy link
Member

Hi @ychemerys
thanks for the contribution. I haven't looked into your PR in depth (yet), but the reason Travis is reporting failures (from make vendor-status) is because we use govendor to manage our dependencies and never patch them locally to avoid drifting from upstream.

I suggest we wait until the mentioned upstream PR is merged and then you can update the vendored library the conventional way, i.e.

govendor fetch github.com/henrikhodne/go-librato/...@new-revision-or-tag

It would be great if you can make that vendor change in a separate PR which we can merge pretty quickly.

@elblivion
Copy link
Contributor

Snap! My colleague @tolgaakyuz was helping me implement tags support for Alerts, we had this running in our Librato account for a few weeks now but had not yet opened a PR.

master...elblivion:alert-tags

@ychemerys maybe there is something there of use for you, hopefully. We only worked on Alerts since we do not yet automate Spaces creation much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants