-
Notifications
You must be signed in to change notification settings - Fork 20
Tags support for Spaces, Charts and Alerts #12
base: master
Are you sure you want to change the base?
Conversation
|
This looks great. I'm not sure if if belongs in this module, but it'd be useful to take a list of required tags as input. Cloudlock currently requires "Env" and "Billing", and it's highly likely Cisco will soon have at least one other tag requirement. |
|
Hi @ychemerys I suggest we wait until the mentioned upstream PR is merged and then you can update the vendored library the conventional way, i.e. It would be great if you can make that vendor change in a separate PR which we can merge pretty quickly. |
|
Snap! My colleague @tolgaakyuz was helping me implement tags support for Alerts, we had this running in our Librato account for a few weeks now but had not yet opened a PR. @ychemerys maybe there is something there of use for you, hopefully. We only worked on Alerts since we do not yet automate Spaces creation much. |
PR with related changes to go-librato: https://github.com/henrikhodne/go-librato/pull/15
Please let me know what can I do to get this merged. Thanks.