-
Notifications
You must be signed in to change notification settings - Fork 584
VAULT-37696: vault_plugin support for enterprise plugins #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* modified: vault/resource_plugin.go modified: vault/resource_plugin_test.go * modified: vault/resource_plugin_test.go
fairclothjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can we also update the docs page since sha is not required except for CE plugins? https://registry.terraform.io/providers/hashicorp/vault/latest/docs/resources/plugin#sha256-1
|
@fairclothjm : Doc has been updated to mark sha256 field as Optional, but still required for non-enteprise plugin |
Description
This PR allow to use vault_plugin ressource for Vault Enteprise Plugin
As the sha should not be defined for enterprise plugin, it has been changed from mandatory to Optionnal
An additionnal check has been added in CustomzeDiff to add sha has mandatory if plugin version not ending with "+ent"
pluginIDRegex Regular Expression has been updated to allow "+" character in the version to allow "+ent"
when plugin is Enterprise, exclude sha from the attrbute retrievec by pluginRead(), so there is no mismatch between what is defined in the hcl code and what is put on the state file
Closes #2518
Checklist
Output from acceptance testing:
Community Note
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.