Feat: optional backend s3 skip kms key id validation #36730
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Reis <[email protected]>
Signed-off-by: Lucio Reis <[email protected]>
Signed-off-by: Lucio Reis <[email protected]>
lucioreisgh
changed the title
|
This PR relates to #34763 |
|
Thanks for this submission! It will be up to the HashiCorp AWS provider team to review this PR. Backends typically are not a high priority for review but I have let them know. Thanks! |
@crw May I ask to send a kind reminder to the team about this PR? This could unblock terraform version upgrade in our environment 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
skip_kms_key_id_validationOption to S3 BackendThis PR adds the option
skip_kms_key_id_validationto the S3 backend.Skipping the validation allows usage of KMS key IDs that trigger errors due to the regex.
Target Release
1.12.x
CHANGELOG entry