build: add docker support #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your input and contribution regarding a docker build for the agent binary. Due to the way the agent updates itself if there is a new version from the server, the agent should be built into the zip and running as this instead of directly from the code. Even if the zip then gets reset on a re-creation of the container, it would avoid that the agent could be stuck in an endless update loop. I created a similar docker support but building a zip first and then include this into the agent in the PR #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for running in a container which is useful in cloud GPU providers.
I am happy to modify the
READMEas well but I didn't want to be too presumptuous.