Add compatibility with template-haskell up to 2.21 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft as I found a build error, fixing... |
nuttycom
force-pushed
the
update_template_haskell
branch
from
43767ca to
2617b5b
Compare
|
Fixed the build for template-haskell 2.18.0 and higher. |
13 tasks
|
Could this change be merged and pushed onto hackage? @liyang |
This was referenced Feb 20, 2023
sellout
approved these changes
May 10, 2024
There was a problem hiding this comment.
I think the changes look good & safe for backward compatibility. Just some comments that might help with maintenance.
Despite there being no CI, there is a tested-with field in the Cabal file. It might be a good idea to add the GHC versions you built this on (one each for TH 2.17, 2.18, and 2.19), so that future contributors know which things shoud work. Adding a GH CI matrix wouldn’t be a bad follow-up PR …
nuttycom
force-pushed
the
update_template_haskell
branch
from
2617b5b to
8f5edca
Compare
nuttycom
changed the title
Finally, yes! 0.2.0.0 is up on hackage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.