Fix lexicographic ordering when timestamps are the same #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great addition, thanks! However, can you maybe also add a section to the readme explaining the issue including a warning that ULIDs are sorted based on the random part, even though this is not necessarily the order they were created in? |
|
Added section already to readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ULIDs are currently not lexicographically sortable unless they have the same timestamp.This is also has alarming consequences where members
Sets ofULIDwill be treated as equal if the timestamps are the same but have different random components.This change ensures that they will be sorted correctly even if the timestamps are identical.
See also: #15